Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extension variable instead of accessing extensions directly #1448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: extension variable instead of accessing extensions directly #1448

wants to merge 1 commit into from
+10 −10

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 28, 2024 •
edited

This PR refactors code to remove duplicated values accessing from extension maps.

@alexandear alexandear changed the title Refactor: simplify map access for extensions refactor: simplify map access for extensions Jan 28, 2024
@alexandear alexandear changed the title refactor: simplify map access for extensions refactor: simplify try and retrieve value from extension map Jan 28, 2024
@alexandear alexandear changed the title refactor: simplify try and retrieve value from extension map refactor: simplify retrieving values from extension map Jan 28, 2024
@alexandear alexandear changed the title refactor: simplify retrieving values from extension map refactor: use extension variables instead of accessing extensions directly Jan 28, 2024
@jamietanna
Copy link
Collaborator

Thanks! Mind rebasing the PR with the latest changes to address conflicts?

@alexandear alexandear force-pushed the refactor-pkg-codegen-extension-map branch from 6aea2b7 to 4eb7011 Compare February 10, 2024 17:22
@alexandear alexandear force-pushed the refactor-pkg-codegen-extension-map branch from 4eb7011 to 899fbf0 Compare February 10, 2024 17:24
@alexandear alexandear changed the title refactor: use extension variables instead of accessing extensions directly refactor: extension variable instead of accessing extensions directly Feb 10, 2024
@alexandear
Copy link
Contributor Author

@jamietanna rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @jamietanna