Fix: Respect parent properties in case of merged schemas by allOf #1415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #697
Currently, oapi-codegen ignores original (parent) fields if
allOf
is defined. OpenAPI schema doesn't seem to refuse a combination of general fields (properties
) andallOf
.For example, the following schema
will be converted into the following type definition, which seems to be wrong result.
The expected result would be like:
The known approach is normalization as proposed in other similar project like
REFACTOR_ALLOF_WITH_PROPERTIES_ONLY
inopneapi-generator
. This PR is inspired by the idea.