Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes type collision for enum values that start with _ (underscore) #1438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes type collision for enum values that start with _ (underscore) #1438

wants to merge 1 commit into from

Conversation

ula
Copy link

@ula ula commented Jan 24, 2024

Resolves an issue with type collision when enum values start with _ (underscore) value.

@jamietanna jamietanna added bug Something isn't working area:enums labels Jan 25, 2024
jamietanna
jamietanna approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jamietanna
Copy link
Collaborator

@ula mind addressing the build failures? Looks like some test changes + running make generate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamietanna jamietanna jamietanna approved these changes

Assignees
No one assigned
Labels
area:enums bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ula @jamietanna @Ulad