Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support withFileTypes in fs.{readdir|readdirSync} #41627

Merged
merged 1 commit into from Mar 21, 2024
Merged

fix: support withFileTypes in fs.{readdir|readdirSync} #41627

merged 1 commit into from Mar 21, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Follow-up to #41582. Support withFileTypes with recursive readdir.

Checklist

Release Notes

Notes: Added support for withFileTypes when calling fs.{readdir|readdirSync} with the recursive in Asar archives.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 19, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 19, 2024
VerteDinde
VerteDinde approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 20, 2024
@jkleinsc jkleinsc merged commit 040acaa into main Mar 21, 2024
25 checks passed
@jkleinsc jkleinsc deleted the withfiletypes-asar branch March 21, 2024 14:22
@release-clerk Release Clerk
Copy link

release-clerk bot commented Mar 21, 2024

Release Notes Persisted

Added support for withFileTypes when calling fs.{readdir|readdirSync} with the recursive in Asar archives.

@trop
Copy link
Contributor

trop bot commented Mar 21, 2024

I was unable to backport this PR to "29-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/29-x-y PR should also be added to the "29-x-y" branch. label Mar 21, 2024
@trop
Copy link
Contributor

trop bot commented Mar 21, 2024

I was unable to backport this PR to "30-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/29-x-y needs-manual-bp/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @jkleinsc @VerteDinde