feat: add support for configuring system network context proxies #41335
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -1468,6 +1468,111 @@ details. | |||
|
|
|||
| **Note:** Enable `Secure Keyboard Entry` only when it is needed and disable it when it is no longer needed. | |||
|
|
|||
| ### `app.setProxy(config)` | |||
There was a problem hiding this comment.
Would we want to name this method more descriptively to distinguish it from ses.setProxy? Something like app.setSessionlessProxy or app.setProxyWithoutSession?
There was a problem hiding this comment.
I prefer the consistency in the API names. The scope of the methods clearly define the boundaries between the two methods, also docs are clear on the difference.
There was a problem hiding this comment.
...the API seems complex to me, but I can't think of how I would simplify it and keep the same flexibility in proxyRule, i.e. the ability to specify [schemas x URIs x fallbacks]. The RFC-like documentation of exactly what's allowed in proxyRules is helpful 👍
API LGTM. My preference would be to see >2 API reviews on this one before merging.
|
Release Notes Persisted
|
|
I was unable to backport this PR to "28-x-y" cleanly; |
|
I have automatically backported this PR to "29-x-y", please check out #41416 |
|
I have automatically backported this PR to "30-x-y", please check out #41417 |
) feat: add support for configuring system network context proxies (#41335)
Description of Change
Follow-up to #40017
Currently there is no way to configure proxy for the net module in the utility process due to network context backend used. Another option would have been to change the network context backend by allowing to configure session property of the net api in the utility process but that is complex since we need to think about how custom protocol and webrequest handlers need to run across process.
Release Notes
Notes: Add proxy configuring support for requests made with net module from utility process