New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_sign_in_ios] Update iOS SDK to 7.1.0 (was: Failing check_podspecs.) #145866
Comments
Skipping the podspec validation now exposes another error in Mac_arm64 ios_platform_tests_shard_1 stable for the package:
Seems to work just fine in |
#6416)" (#6419) Reverts: #6416 Initiated by: ditman Reason for reverting: Failures happen (later) in other plugins (more updates in the related issue) flutter/flutter#145866 Original PR Author: ditman Reviewed By: {jmagman} This change reverts the following previous change: Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. **To be removed soon!**
This seems to be related to the update of the GoogleSignIn iOS SDK to version 7.1.0. See:
I've posted a PR to pin our package to the 7.0.0 version, here: (But we definitely want to update to 7.1.0, because it comes with Privacy Manifest) |
A proper fix for this issue exists here: |
This PR temporarily pins the GoogleSignIn iOS SDK to version 7.0.0 in the darwin podspec configuration. This'll enable our CI to keep going, until a more proper fix to `google_sign_in_ios` lands, with an update to the latest [7.1 version](https://github.com/google/GoogleSignIn-iOS/releases). See: * flutter/flutter#145866 For more information about the current CI failures. ## Testing This PR should help with the tests that are currently broken in CI.
1. Update GoogleSignIn iOS SDK dependency to [7.1](https://github.com/google/GoogleSignIn-iOS/releases/tag/7.1.0), which supports privacy manifests. 1. Update "fetch deps step" to run `pod repo update` every time to avoid missing spec failure. Also added a fetch deps step to the all_packages builds, since those could also use a `pod repo update` but I didn't want to add more logic to those bash scripts. ``` [!] CocoaPods could not find compatible versions for pod "GoogleSignIn": In Podfile: google_sign_in_ios (from `Flutter/ephemeral/.symlinks/plugins/google_sign_in_ios/darwin`) was resolved to 0.0.1, which depends on GoogleSignIn (~> 7.1) None of your spec sources contain a spec satisfying the dependency: `GoogleSignIn (~> 7.1)`. ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752192509749702705/+/u/Run_package_tests/download_Dart_and_iOS_deps/stdout 3. Looks like the new versions of [`GTMSessionFetcher`](https://github.com/CocoaPods/Specs/blob/master/Specs/c/e/3/GTMSessionFetcher/3.3.2/GTMSessionFetcher.podspec.json) and [`AppAuth`](https://github.com/CocoaPods/Specs/blob/master/Specs/b/b/9/AppAuth/1.7.3/AppAuth.podspec.json) don't define modules, so there's an error building it statically: ``` [!] The following Swift pods cannot yet be integrated as static libraries: The Swift pod `GTMAppAuth` depends upon `GTMSessionFetcher` and `AppAuth`, which do not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies. ``` I filed google/gtm-session-fetcher#384 and openid/AppAuth-iOS#844. In the meantime, I updated the example apps to `use_frameworks!`, which would be on for Flutter Swift apps, but not Objective-C ones. We could add something to the tool to detect this case, and suggest `use_frameworks!` be added? 4. Even though google_sign_in_ios does not contain Swift files, for some reason, there is a "pod lib lint" warning complaining `swift_version` isn't set. This seems related to `GTMAppAuth` dependency constraint that went from an Objective-C-only to Swift pod. So I set `swift_version` since it's harmless. ``` - WARN | swift: The validator used Swift `4.0` by default because no Swift version was specified. To specify a Swift version during validation, add the `swift_versions` attribute in your podspec. Note that usage of a `.swift-version` file is now deprecated. ``` https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752100979634945505/+/u/Run_package_tests/validate_iOS_and_macOS_podspecs/stdout ## Issues * Fixes flutter/flutter#145777 * Fixes flutter/flutter#145866 * See also flutter/flutter#137140
The recent update of the GoogleSignIn iOS SDK to v7.1.0 seems to have broken our CI in 2 ways:
As a mitigation, the version of the SDK has been pinned to 7.0.0, here:
But the pin needs to be cleaned up.
Earlier description
The "Mac_x64 check_podspecs" seems to be consistently failing in flutter/packages; there's a warning while checking google_sign_in_os:
(Example of the Failure.)
In the meantime,Reverted, as the change exposed another issue, mentioned below!--allow-warnings
has been added topodspec_check_command.dart
to unblock the tree. (Please, revert flutter/packages#6416 as part of this fix!)The text was updated successfully, but these errors were encountered: