Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine clang crash receipie logic error #142232

Closed
jonahwilliams opened this issue Jan 25, 2024 · 6 comments
Closed

Engine clang crash receipie logic error #142232

jonahwilliams opened this issue Jan 25, 2024 · 6 comments
Labels
P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@jonahwilliams
Copy link
Member

Type of Request

bug

Infrastructure Environment

Luci

What is happening?

See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8757912241942054849/+/u/RECIPE_CRASH__Uncaught_exception_/logging

The recipie for catching clang crash errors seems to have a problem with a missing map key.

Steps to reproduce

Step 1:
Step 2:
..
Step n:

Expected results

I expect to see X when Y is finished.
@jonahwilliams jonahwilliams added the team-infra Owned by Infrastructure team label Jan 25, 2024
@jonahwilliams
Copy link
Member Author

FYI @keyonghan

@keyonghan
Copy link
Contributor

I will take a look.

@keyonghan keyonghan added P2 Important issues not at the top of the work list triaged-infra Triaged by Infrastructure team labels Jan 25, 2024
@keyonghan keyonghan self-assigned this Jan 25, 2024
@keyonghan
Copy link
Contributor

The real failure is

FAILED: obj/flutter/impeller/entity/geometry/entity.vertices_geometry.o 
/b/s/w/ir/cache/goma/client/gomacc ../../buildtools/linux-x64/clang/bin/clang++ -MD -MF obj/flutter/impeller/entity/geometry/entity.vertices_geometry.o.d -D_USE_MATH_DEFINES -DUSE_OPENSSL=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_AVAILABILITY=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D_DEBUG -D_GLIBCXX_DEBUG=1 -DIMPELLER_DEBUG=1 -DIMPELLER_ENABLE_CAPTURE=1 -DIMPELLER_SUPPORTS_RENDERING=1 -DIMPELLER_ENABLE_OPENGLES=1 -DIMPELLER_ENABLE_VULKAN=1 -DIMPELLER_ENABLE_VULKAN_PLAYGROUNDS=1 -DSK_FONTMGR_ANDROID_AVAILABLE -DSK_TYPEFACE_FACTORY_FREETYPE -DSK_FONTMGR_FREETYPE_DIRECTORY_AVAILABLE -DSK_FONTMGR_FREETYPE_EMBEDDED_AVAILABLE -DSK_FONTMGR_FREETYPE_EMPTY_AVAILABLE -DSK_GL -DSK_ENABLE_DUMP_GPU -DSK_VULKAN -DSK_CODEC_DECODES_JPEG -DSK_CODEC_DECODES_PNG -DSK_CODEC_DECODES_WEBP -DSK_HAS_WUFFS_LIBRARY -DSK_XML -DFLUTTER_RUNTIME_MODE_DEBUG=1 -DFLUTTER_RUNTIME_MODE_PROFILE=2 -DFLUTTER_RUNTIME_MODE_RELEASE=3 -DFLUTTER_RUNTIME_MODE_JIT_RELEASE=4 -DDART_LEGACY_API=\[\[deprecated\]\] -DFLUTTER_RUNTIME_MODE=1 -DFLUTTER_JIT_RUNTIME=1 -I../.. -Igen -I../../third_party/libcxx/include -I../../third_party/libcxxabi/include -I../../flutter/build/secondary/third_party/libcxx/config -I../../flutter -Igen/flutter -Igen/flutter/impeller/runtime_stage -I../../flutter/third_party/flatbuffers/include -Wthread-safety-analysis -fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64 -march=x86-64 -fPIC -pipe -pthread -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-but-set-parameter -Wno-unused-but-set-variable -Wno-implicit-int-float-conversion -Wno-deprecated-copy -Wno-psabi -Wno-deprecated-literal-operator -Wno-unqualified-std-cast-call -Wno-non-c-typedef-for-linkage -Wno-range-loop-construct -fvisibility=hidden --sysroot=../../build/linux/debian_sid_amd64-sysroot -Wstring-conversion -Wnewline-eof -O0 -g2 -Wno-newline-eof -Wunreachable-code -fvisibility-inlines-hidden -std=c++17 -fno-rtti -nostdinc++ -nostdinc++ -fvisibility=hidden -fno-exceptions   -c ../../flutter/impeller/entity/geometry/vertices_geometry.cc -o obj/flutter/impeller/entity/geometry/entity.vertices_geometry.o && sed -i 's@/b/f/w@../..@g' obj/flutter/impeller/entity/geometry/entity.vertices_geometry.o.d
../../flutter/impeller/entity/geometry/vertices_geometry.cc:157:10: error: unused variable 'i' [-Werror,-Wunused-variable]
  157 |   size_t i = 0u;
      |          ^
1 error generated.
[6984/7467] ACTION //flutter/lib/snapshot:strong_platform(//build/toolchain/linux:clang_x64)
ninja: build stopped: subcommand failed.

But there is also an infra issue. A new env. was recently added to collect clang crash files and the framework_smoke recipes missed that. https://flutter-review.googlesource.com/c/recipes/+/54582 to add it.

@keyonghan
Copy link
Contributor

The recipe CL landed. Moving to Engine for the build failure.

@keyonghan keyonghan removed their assignment Jan 29, 2024
@keyonghan keyonghan added team-engine Owned by Engine team fyi-infra For the attention of Infrastructure team and removed team-infra Owned by Infrastructure team labels Jan 29, 2024
@flutter-triage-bot flutter-triage-bot bot removed fyi-infra For the attention of Infrastructure team triaged-infra Triaged by Infrastructure team labels Jan 30, 2024
@zanderso zanderso added the triaged-engine Triaged by Engine team label Feb 5, 2024
XuanTung95 pushed a commit to XuanTung95/recipes that referenced this issue Feb 14, 2024
@keyonghan
Engine env setup for framework_smoke recipes
e306bb5 
Change-Id: Id887a5119db3a3dd5512a41f9ebc0b91ebb84a01
Bug: flutter/flutter#142232
Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/54582
Commit-Queue: Keyong Han <keyonghan@google.com>
Reviewed-by: Ricardo Amador <ricardoamador@google.com>
@zanderso
Copy link
Member

This looks stale. Closing.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zanderso @jonahwilliams @keyonghan