New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing commas in android dependency version checking gradle plugin #145718
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
For reference: What's new in Kotlin 1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
@gmackall what do we currently have as the minimum supported version of kotlin? |
flutter/flutter@89ea492...8528881 2024-03-29 34871572+gmackall@users.noreply.github.com Remove trailing commas in android dependency version checking gradle plugin (flutter/flutter#145718) 2024-03-29 polinach@google.com Upgrade leak_tracker. (flutter/flutter#145940) 2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) (flutter/flutter#145946) 2024-03-29 103135467+sealesj@users.noreply.github.com Refactor flutter_plugins (flutter/flutter#145870) 2024-03-29 34871572+gmackall@users.noreply.github.com Point kotlin message in `gradle_errors.dart` towards new place where templates define the kotlin version (flutter/flutter#145936) 2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) (flutter/flutter#145941) 2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) (flutter/flutter#145938) 2024-03-28 31859944+LongCatIsLooong@users.noreply.github.com `RenderFlex` baseline intrinsics (flutter/flutter#145483) 2024-03-28 godofredoc@google.com Use reporter extended consistently. (flutter/flutter#145617) 2024-03-28 36861262+QuncCccccc@users.noreply.github.com Update tokens to v2.3.5 (flutter/flutter#145356) 2024-03-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from a396dc1a03a9 to c176d114d01e (2 revisions) (flutter/flutter#145934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
We currently warn for below 1.5, and don't error for any version |
Adds a kotlin linting step to the linux analyze check, using a version of [ktlint](https://github.com/pinterest/ktlint) hosted on [CIPD](https://chrome-infra-packages.appspot.com/p/flutter/ktlint/linux-amd64/+/version_1_1_1). Configured to disallow trailing commas, because of (and now acting as a test for) #145718. Because of this configuration the PR also removes some trailing commas in some kotlin files. Also checks in a baseline file.
Apparently old versions of kotlin (pre 1.4) don't allow trailing commas.
Example logs: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752506486861217537/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.