Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate test metrics consistently. #145943

Merged
merged 3 commits into from Mar 29, 2024
Merged

Generate test metrics consistently. #145943

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c071f67
Generate test metrics consistently.
godofredoc Mar 28, 2024
0310eea
Simplify temp file creation.
godofredoc Mar 29, 2024
dcec28d
Add more context about the metrics file deletion.
godofredoc Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 24 additions & 1 deletion dev/bots/test.dart
View file
Open in desktop
Expand Up @@ -1665,11 +1665,15 @@ Future<void> runFlutterWebTest(
List<String> tests,
bool useWasm,
) async {
const LocalFileSystem fileSystem = LocalFileSystem();
final String suffix = DateTime.now().microsecondsSinceEpoch.toString();
final File metricFile = fileSystem.systemTempDirectory.childFile('metrics_$suffix.json');
await runCommand(
flutter,
<String>[
'test',
'--reporter=expanded',
'--file-reporter=json:${metricFile.path}',
'-v',
'--platform=chrome',
if (useWasm) '--wasm',
Expand All @@ -1683,6 +1687,10 @@ Future<void> runFlutterWebTest(
'FLUTTER_WEB': 'true',
},
);
// metriciFile is a transitional file that needs to be deleted once it is parsed.
// TODO(godofredoc): Ensure metricFile is parsed and aggregated before deleting.
// https://github.com/flutter/flutter/issues/146003
metricFile.deleteSync();
godofredoc marked this conversation as resolved.
Show resolved Hide resolved
}


Expand Down Expand Up @@ -1724,7 +1732,8 @@ Future<void> _runDartTest(String workingDirectory, {
}

const LocalFileSystem fileSystem = LocalFileSystem();
final File metricFile = fileSystem.file(path.join(flutterRoot, 'metrics.json'));
final String suffix = DateTime.now().microsecondsSinceEpoch.toString();
final File metricFile = fileSystem.systemTempDirectory.childFile('metrics_$suffix.json');
final List<String> args = <String>[
'run',
'test',
Expand Down Expand Up @@ -1787,6 +1796,11 @@ Future<void> _runDartTest(String workingDirectory, {
print('Failed to generate metrics: $e');
}
}

// metriciFile is a transitional file that needs to be deleted once it is parsed.
// TODO(godofredoc): Ensure metricFile is parsed and aggregated before deleting.
// https://github.com/flutter/flutter/issues/146003
metricFile.deleteSync();
}

Future<void> _runFlutterTest(String workingDirectory, {
Expand All @@ -1809,9 +1823,13 @@ Future<void> _runFlutterTest(String workingDirectory, {
tags.addAll(<String>['-t', 'reduced-test-set']);
}

const LocalFileSystem fileSystem = LocalFileSystem();
final String suffix = DateTime.now().microsecondsSinceEpoch.toString();
final File metricFile = fileSystem.systemTempDirectory.childFile('metrics_$suffix.json');
final List<String> args = <String>[
'test',
'--reporter=expanded',
'--file-reporter=json:${metricFile.path}',
if (shuffleTests && !_isRandomizationOff) '--test-randomize-ordering-seed=$shuffleSeed',
if (fatalWarnings) '--fatal-warnings',
...options,
Expand Down Expand Up @@ -1849,6 +1867,11 @@ Future<void> _runFlutterTest(String workingDirectory, {
environment: environment,
);

// metriciFile is a transitional file that needs to be deleted once it is parsed.
// TODO(godofredoc): Ensure metricFile is parsed and aggregated before deleting.
// https://github.com/flutter/flutter/issues/146003
metricFile.deleteSync();

if (outputChecker != null) {
final String? message = outputChecker(result);
if (message != null) {
Expand Down