Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor realm_checker #145905

Merged
merged 6 commits into from Apr 1, 2024
Merged

Conversation

sealesj
Copy link
Contributor

@sealesj sealesj commented Mar 28, 2024

Refactor realm_checker suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing realm_checker tests

Part of #145482

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj added the team-infra Owned by Infrastructure team label Mar 28, 2024
@sealesj sealesj self-assigned this Mar 28, 2024
@sealesj sealesj marked this pull request as ready for review March 28, 2024 15:38
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dev/bots/suite_runners/run_realm_checker_tests.dart Outdated Show resolved Hide resolved
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
Copy link
Contributor

auto-submit bot commented Mar 28, 2024

auto label is removed for flutter/flutter/145905, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
Copy link
Contributor

auto-submit bot commented Mar 28, 2024

auto label is removed for flutter/flutter/145905, due to Pull request flutter/flutter/145905 is not in a mergeable state.

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
Copy link
Contributor

auto-submit bot commented Mar 28, 2024

auto label is removed for flutter/flutter/145905, due to - The status or check suite Mac framework_tests_impeller has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
Copy link
Contributor

auto-submit bot commented Mar 29, 2024

auto label is removed for flutter/flutter/145905, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024
@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2024
@auto-submit auto-submit bot merged commit f8a06f6 into flutter:master Apr 1, 2024
133 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 2, 2024
…6448)

Manual roll requested by tarrinneal@google.com

flutter/flutter@9d32f07...7fa932b

2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from e6f19409b613 to ea93c5d91b12 (3 revisions) (flutter/flutter#146100)
2024-04-01 103135467+sealesj@users.noreply.github.com Refactor realm_checker (flutter/flutter#145905)
2024-04-01 kallentu@google.com Add info strings to code blocks. (flutter/flutter#146085)
2024-04-01 sokolovskyi.konstantin@gmail.com Add test for animated_container.0.dart API example. (flutter/flutter#145995)
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8dff6b833fe2 to e6f19409b613 (2 revisions) (flutter/flutter#146093)
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from d33666d90916 to 8dff6b833fe2 (3 revisions) (flutter/flutter#146087)
2024-04-01 katelovett@google.com Fix SliverMainAxisGroup layout in reverse (flutter/flutter#145572)
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from dd4f5cd5c9d5 to d33666d90916 (3 revisions) (flutter/flutter#146083)
2024-04-01 engine-flutter-autoroll@skia.org Roll Packages from 51faaa1 to d5aff19 (3 revisions) (flutter/flutter#146081)
2024-04-01 102401667+Dimilkalathiya@users.noreply.github.com Fixes some gesture recognizers are not disposed. (flutter/flutter#146072)
2024-04-01 barpac02@gmail.com Flutter Gradle Plugin: add versionName and versionCode to FlutterExtension (flutter/flutter#146044)
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from bf348cd73d49 to dd4f5cd5c9d5 (1 revision) (flutter/flutter#146071)
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 984a78b04671 to bf348cd73d49 (1 revision) (flutter/flutter#146065)
2024-04-01 tessertaha@gmail.com Deprecate `ButtonBar`, `ButtonBarThemeData`, and `ThemeData.buttonBarTheme` (flutter/flutter#145523)
2024-04-01 tessertaha@gmail.com Add `DataColumn.headingRowAlignment ` for `DataTable` (flutter/flutter#144006)
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from e9d35f8bfbe2 to 984a78b04671 (2 revisions) (flutter/flutter#146062)
2024-04-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f6b832c8e33 to e9d35f8bfbe2 (1 revision) (flutter/flutter#146060)
2024-03-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9689390986b7 to 4f6b832c8e33 (1 revision) (flutter/flutter#146055)
2024-03-31 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34081fea4d59 to 9689390986b7 (1 revision) (flutter/flutter#146053)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants