Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix params underscore convert to dash. #6203

Merged
merged 2 commits into from Mar 22, 2024
Merged

Conversation

dranger003
Copy link
Contributor

@dranger003 dranger003 commented Mar 21, 2024

Fixes #6191. Arguments containing _ were previously automatically converted to -, this PR restores that functionaly.

common/common.cpp Outdated Show resolved Hide resolved
@slaren slaren merged commit fa046ea into ggerganov:master Mar 22, 2024
38 of 44 checks passed
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
* Fix params underscore convert to dash.

* Update common/common.cpp

---------

Co-authored-by: slaren <slarengh@gmail.com>
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 3, 2024
* Fix params underscore convert to dash.

* Update common/common.cpp

---------

Co-authored-by: slaren <slarengh@gmail.com>
@dranger003 dranger003 deleted the fix-params branch April 5, 2024 17:59
tybalex pushed a commit to tybalex/function.cpp that referenced this pull request Apr 17, 2024
* Fix params underscore convert to dash.

* Update common/common.cpp

---------

Co-authored-by: slaren <slarengh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error: unknown argument: --ctx-size" after llama.cpp update.
2 participants