cuda : rename build flag to LLAMA_CUDA #6299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Mar 25, 2024
|
This also renames some targets in the RPM packages. cc @jboero |
|
Thanks for the heads-up. I can switch this easy enough. |
jboero
added a commit
to jboero/llama.cpp
that referenced
this pull request
Mar 25, 2024
This is being changed in Make. ggerganov#6299
|
Not sure why the nix CI is not completing, it seems to have timed out after 6 hours. The same things seems to be happening on master, so I don't think this PR is the cause. |
|
I think starting with this PR the nix CI is rebuilding ROCm each time (and timing out after 6 hours each time). In the previous merged PR #6298 and before nix ubuntu build was taking 22-23 minutes. |
|
You can see the previous commit in master the nix run being cancelled after 5 hours (when this was merged). |
13 tasks
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 3, 2024
gentoo-repo-qa-bot
pushed a commit
to gentoo-mirror/bratishkaerik-overlay
that referenced
this pull request
Apr 13, 2024
Following upstream here: ggerganov/llama.cpp#6299 . Signed-off-by: Eric Joldasov <bratishkaerik@landless-city.net>
tybalex
pushed a commit
to tybalex/function.cpp
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLAMA_CUBLASstill works for now to avoid breaking build scripts, but it prints a warning announcing that it will be removed in the future.GGML_USE_CUBLASis also renamed toGGML_USE_CUDA.