Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# Dev Kit extension #1163

Merged
merged 2 commits into from Apr 24, 2024
Merged

Add C# Dev Kit extension #1163

merged 2 commits into from Apr 24, 2024

Conversation

ArinGhazarian
Copy link
Collaborator

@ArinGhazarian ArinGhazarian commented Nov 14, 2023

This PR adds C# Dev Kit to the extensions list. It will install the C# extension and has a built in test explorer.

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

Copy link

github-actions bot commented Nov 14, 2023

Unit Test Results

810 tests   810 ✅  22s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit e4aafff.

♻️ This comment has been updated with latest results.

@@ -15,8 +15,7 @@
"vscode": {
// Add the IDs of extensions you want installed when the container is created.
"extensions": [
"ms-dotnettools.csharp",
"formulahendry.dotnet-test-explorer",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# Dev Kit has a built in test explorer so I guess we don't need this anymore.

@ArinGhazarian ArinGhazarian marked this pull request as ready for review November 14, 2023 20:40
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
gei 79% 70% 519
Octoshift 87% 76% 1272
ado2gh 84% 78% 627
bbs2gh 78% 73% 651
Summary 83% (6821 / 8172) 75% (1534 / 2044) 3069

@jeviet jeviet merged commit 2fc08d1 into main Apr 24, 2024
30 checks passed
@jeviet jeviet deleted the update-dev-container branch April 24, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants