Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedding factorization in roberta #30528

Closed
wants to merge 2 commits into from

Conversation

ming0308uk
Copy link

@ming0308uk ming0308uk commented Apr 28, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ming0308uk
Copy link
Author

I am very new to making pull requests.

Could someone please tell me if the test failures mentioned above are occurring in the main branch or if they are caused by my pull request?

Thank you.

@ming0308uk ming0308uk closed this Apr 28, 2024
@ming0308uk ming0308uk deleted the my-roberta branch April 28, 2024 21:04
@ming0308uk ming0308uk restored the my-roberta branch April 28, 2024 21:04
@ming0308uk ming0308uk deleted the my-roberta branch April 28, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant