Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix README path #540

Merged
merged 2 commits into from Mar 10, 2024
Merged

doc: Fix README path #540

merged 2 commits into from Mar 10, 2024

Conversation

yashi
Copy link
Member

@yashi yashi commented Mar 10, 2024

I've been testing and building doc with

cd doc
cmake -B builddir
ninja -C builddir

In this case README.md is two dirs up.

However, the "official" way, or our CI's way, to build doc is

cmake -B build-docs -S doc
cmake --build build-docs

With this, README.md is at the parent dir. I'd be nice if we can write CWD independent way but this one needs a quick hot fix.

I've been testing and building doc with

    cd doc
    cmake -B builddir
    ninja -C builddir

In this case README.md is two dirs up.

However, the "official" way, or our CI's way, to build doc is

    cmake -B build-docs -S doc
    cmake --build build-docs

With this, README.md is at the parent dir.  I'd be nice if we can
write CWD independent way but this one needs a quick hot fix.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
Test the document build process for pull requests to ensure its
success before merging.

Signed-off-by: Yasushi SHOJI <yashi@spacecubics.com>
@yashi yashi merged commit 5df2f15 into libcsp:develop Mar 10, 2024
23 checks passed
@yashi yashi deleted the doc-fix-readme-path branch March 10, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant