Set default font size for code lines #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes line cropping that users may experience if they set custom font size in the browser settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes line cropping that users may experience if they set custom font size in the browser settings
Problem explained in images:
What it looks like now:
The settings in chrome that I have (and that many other people may have):
What it looks like after the fix:
Why this fix is okay for a11y:
I want to emphasize that this is a quick fix that should ideally be temporary. It's best to later change the hardcoded
height: 15pxvalues to something that respects the currentremsize.At the same time, this quick fix is a good solution because you no longer see cropped text (which is hard to read by itself) and also if someone wishes to make their text larger, the zoom-in combo command++ still works.