Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defcustom for generated file extension, manage toc #20

Merged
merged 2 commits into from Mar 16, 2024

Conversation

PierreTechoueyres
Copy link
Contributor

@PierreTechoueyres PierreTechoueyres commented Mar 14, 2024

  • Add defcustom for generated file extension as consensus about what it should be doesn't exists,
  • Add support for table of content and depth if specified.

@yashi
Copy link
Owner

yashi commented Mar 15, 2024

Hi @PierreTechoueyres,

Thank for the PR!

It seems some tests are failing. Would you mind taking a look at?
I can do that if you want me to.

@PierreTechoueyres
Copy link
Contributor Author

Will do tomorrow if you don't mind waiting until that.

@yashi
Copy link
Owner

yashi commented Mar 15, 2024

@PierreTechoueyres No problem at all. Take your time 😃

Copy link
Owner

@yashi yashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@yashi yashi merged commit d673685 into yashi:master Mar 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants