Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes corvus in favor of sentry and analytics client #3891

Merged
merged 6 commits into from Jan 16, 2023
Merged

Removes corvus in favor of sentry and analytics client #3891

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
10caf8f
Removes corvus in favor of sentry and analytics client
otaviojacobi Nov 29, 2022
41fca03
Removes corvus in favor of sentry and analytics client
otaviojacobi Nov 29, 2022
f3f7ecb
Unifying sentry reports in a single project
aethernet Jan 6, 2023
2b728d3
Remove personal path on etcher
otaviojacobi Jan 6, 2023
6c417e3
patch: Sentry fix path
aethernet Jan 6, 2023
86d43a5
Anonymizes all paths before sending
otaviojacobi Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Unifying sentry reports in a single project 
Change-type: patch
  • Loading branch information
@aethernet @otaviojacobi
aethernet authored and otaviojacobi committed Jan 12, 2023
commit f3f7ecb852503d4d97dbe6a78bf920ca177bddd1
28 changes: 1 addition & 27 deletions .github/actions/publish/action.yml
View file
Open in desktop
Expand Up @@ -72,32 +72,6 @@ runs:
chmod +x "$(dirname "$(which node)")/resinci-deploy" && which resinci-deploy
fi

# FIXME: store sentry workflow is not documented
# https://github.com/product-os/resinci-deploy/blob/master/lib/sentry.ts
# https://github.com/getsentry/sentry-cli
# https://docs.sentry.io/api/projects/create-a-new-client-key/
- name: Generate Sentry DSN
id: sentry
shell: bash --noprofile --norc -eo pipefail -x {0}
run: |
set -ea

[[ '${{ inputs.VERBOSE }}' =~ on|On|Yes|yes|true|True ]] && set -x

branch="$(echo '${{ github.event.pull_request.head.ref }}' | sed 's/[^[:alnum:]]/-/g')"

stdout="$(resinci-deploy store sentry \
--branch="${branch}" \
--name="$(jq -r '.name' package.json)" \
--team="$(yq e '.sentry.team' repo.yml)" \
--org="$(yq e '.sentry.org' repo.yml)" \
--type="$(yq e '.sentry.type' repo.yml)")"

echo "dsn=$(echo "${stdout}" | tail -n 1)" >> $GITHUB_OUTPUT

env:
SENTRY_TOKEN: ${{ fromJSON(inputs.secrets).SENTRY_AUTH_TOKEN }}

# https://www.electron.build/code-signing.html
# https://github.com/Apple-Actions/import-codesign-certs
- name: Import Apple code signing certificate
Expand Down Expand Up @@ -171,7 +145,7 @@ runs:

for target in ${TARGETS}; do
electron-builder ${ELECTRON_BUILDER_OS} ${target} ${ARCHITECTURE_FLAGS} \
--c.extraMetadata.analytics.sentry.token='${{ steps.sentry.outputs.dsn }}' \
--c.extraMetadata.analytics.sentry.token='https://739bbcfc0ba4481481138d3fc831136d@o95242.ingest.sentry.io/4504451487301632' \
aethernet marked this conversation as resolved.
Show resolved Hide resolved
--c.extraMetadata.analytics.amplitude.token='balena-etcher' \
--c.extraMetadata.packageType="${target}"

Expand Down