Allow GitHub pre-release(s) #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5dda36
to
5b4526d
Compare
|
Related to balena-io/etcher#3853 |
pipex
reviewed
Dec 2, 2022
0acb583
to
94e28b3
Compare
klutchell
reviewed
Dec 5, 2022
94e28b3
to
02ccfae
Compare
klutchell
approved these changes
Dec 5, 2022
Change-type: patch
02ccfae
to
ec8de76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows projects like Etcher to be configured to not make every release final, thus avoiding signalling potentially garbage/invalid releases to the world.
It is entirely possible for all Etcher tests to pass with flying colours (green that is) and still not work once installed on one or more platforms. One way to gain more confidence here is to expand Etcher test coverage, implementing proper e2e tests, but we are not there yet.
So, setting
github_prerelease: trueon Etcher repository will create GH releases and enable manual testing to take place before marking a release final/latest.cc @aethernet @zwhitchcox @mcraa